use checked casts and arithmetic in Miri engine#70226
Merged
bors merged 11 commits intorust-lang:masterfrom Mar 25, 2020
Merged
use checked casts and arithmetic in Miri engine#70226bors merged 11 commits intorust-lang:masterfrom
bors merged 11 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unfortunately pretty annoying because we have to cast back and forth between
u64andusizemore often that should be necessary, and that cast is considered fallible.For example, should this really be
usize?Also,
LayoutDetailsusesusizefor field indices, but in Miri we useu64to be able to also handle array indexing. Maybe methods likemplace_fieldshould be suitably generalized to accept bothu64andusize?r? @oli-obk Cc @eddyb